-
Notifications
You must be signed in to change notification settings - Fork 178
QuadSPI API documentation #354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QuadSPI API documentation #354
Conversation
Make minor copy edits, mostly for active voice and formatting for rendering.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review my copy edits, and make sure I didn't accidentally change the meaning of anything.
Note to self: Merge after the updated Doxy kicks in. Also, inform web team of image when merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy edit looks good to me, Thanks..
@AnotherButler Where do we define this is feature driver, it is on the branch. Means its under development (contributions welcome) ? I expect that as its feature branch, we receive feedback from partners, community that could potentially lead to changes. I get an impression from reading this document that QSPI was released and it's ready for production |
@0xc0170 This is a placeholder. Because we don't know when or how this will be delivered, we created it here for now. It will not be merged or added to the .json. Instead, it will be moved to the decided delivery method once we know what that is. |
Some questions primarily in regards to the linked example for now: https://os.mbed.com/teams/mbed_example/code/mbed-os-example-qspi/file/cc0165946232/main.cpp/ @AnotherButler Will ping an appropriate engineer when I hear back about who that is, should be tomorrow. EDIT: @0xc0170 @maciejbocianski Is this the final example we plan on using? I like the actual functionality of it rather than just creating a QSPI instance and doing nothing with it, but the example seems like a bit much at first blush compared to our other examples. While we need more examples like this, should we have a smaller stepping stone example not tied to specific hardware in addition to this? I'm not too familiar with the QSPI feature so may not really be reasonable just throwing it out there. In case this is the final example proposal, a few minor nits:
myQspi = new QSPI((PinName)QSPI_PIN_IO0, (PinName)QSPI_PIN_IO1, (PinName)QSPI_PIN_IO2, (PinName)QSPI_PIN_IO3, (PinName)QSPI_PIN_SCK, (PinName)QSPI_PIN_CSN);
tx_buf[] = "HELLO QUAD-SPI!";
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Certainly sample app should be improved.
Who can fix the example? |
@maciejbocianski is listed as the developer in the teams example, would you be able to clean up the example? Senthil will be out for another ~1.5 weeks. |
@kegilbert @AnotherButler sure thing, I will do it tomorrow |
Thanks! |
Fix links for proper rendering.
Fix broken link.
Standardize naming across documents.
@AnotherButler @kegilbert @0xc0170 @SenRamakri Please review |
This provides Quad SPI driver API documentation. Note that the QuadSPI implementation will be in a feature branch for 5.7 release.