Skip to content

Make PR from #324 #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 11, 2017
Merged

Make PR from #324 #358

merged 2 commits into from
Dec 11, 2017

Conversation

AnotherButler
Copy link
Contributor

Make new PR from old PR I'm closing to avoid merge conflicts.

Make PR from #324
e7a1afa 
Make new PR from old PR I'm closing to avoid merge conflicts.
@AnotherButler AnotherButler mentioned this pull request Dec 11, 2017
Closed
kegilbert
kegilbert approved these changes Dec 11, 2017
View reviewed changes
Copy link
Contributor

@kegilbert kegilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Amanda is talking to me now about us missing the image Sam requested, but we can likely merge as is and create a ticket to add the image later.

Fix link in storage.md
8f3f9b8 
Add link for clarity.
@AnotherButler AnotherButler merged commit 9069cad into new_engine Dec 11, 2017
@AnotherButler AnotherButler deleted the AnotherButler-patch-2 branch December 11, 2017 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kegilbert kegilbert kegilbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnotherButler @kegilbert