Skip to content

Updated ethernet and wifi interface description #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2018
Merged

Updated ethernet and wifi interface description #472

merged 2 commits into from
Apr 17, 2018

Conversation

mikaleppanen
Copy link

@mikaleppanen mikaleppanen commented Mar 27, 2018

This is ready for review.

@mikaleppanen
Copy link
Author

@SeppoTakalo Could you check if these changes look valid?

@SeppoTakalo
Copy link
Contributor

What does "wait to merge" label mean?

How long does this need to wait? In case I need to modify same files, I need to pick this same change to my PR in order to avoid conflicts.

@AnotherButler
Copy link
Contributor

I added the "wait to merge" label because the description states that this is a work in progress and asks me not to review it yet. If this is ready for review, I am happy to delete the label.

@SeppoTakalo
Copy link
Contributor

@mikaleppanen Please remove the "work in progress" label, as discussed.

@AnotherButler This is now complete and follow up work will be done in #470

@mikaleppanen
Copy link
Author

Removed the work in progress.

@SeppoTakalo
Copy link
Contributor

Looks OK, can be merged.

@AnotherButler
Copy link
Contributor

Please review my changes and resolve merge conflicts.

@mikaleppanen mikaleppanen changed the title Updated ethernet and wifi interface description Updated ethernet and wifi interface description Apr 13, 2018
Amanda Butler added 2 commits April 13, 2018 09:48
Copy edit file for correct use of bullets and numbers and for parallelism.
Copy edit file, mostly for correct use of bullets and numbers and organization.
@mikaleppanen
Copy link
Author

Resolved merge conflicts.

@AnotherButler
Copy link
Contributor

@mikaleppanen Is it OK to make these changes to the live 5.8 docs, too? There's no content that only applies to 5.9, right?

@mikaleppanen
Copy link
Author

@AnotherButler Yes, it is ok. These changes are valid also to 5.8.

@AnotherButler AnotherButler merged commit 508bd80 into ARMmbed:new_engine Apr 17, 2018
AnotherButler pushed a commit that referenced this pull request Apr 17, 2018
Make changes from PR #472 to live site after reviewing on test site.
AnotherButler pushed a commit that referenced this pull request Apr 17, 2018
Make changes from #472 after reviewing on test site.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants