-
Notifications
You must be signed in to change notification settings - Fork 178
Updated ethernet and wifi interface description #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated ethernet and wifi interface description #472
Conversation
@SeppoTakalo Could you check if these changes look valid? |
What does "wait to merge" label mean? How long does this need to wait? In case I need to modify same files, I need to pick this same change to my PR in order to avoid conflicts. |
I added the "wait to merge" label because the description states that this is a work in progress and asks me not to review it yet. If this is ready for review, I am happy to delete the label. |
@mikaleppanen Please remove the "work in progress" label, as discussed. @AnotherButler This is now complete and follow up work will be done in #470 |
Removed the work in progress. |
Looks OK, can be merged. |
Please review my changes and resolve merge conflicts. |
Copy edit file for correct use of bullets and numbers and for parallelism.
Copy edit file, mostly for correct use of bullets and numbers and organization.
Resolved merge conflicts. |
@mikaleppanen Is it OK to make these changes to the live 5.8 docs, too? There's no content that only applies to 5.9, right? |
@AnotherButler Yes, it is ok. These changes are valid also to 5.8. |
Make changes from PR #472 to live site after reviewing on test site.
Make changes from #472 after reviewing on test site.
This is ready for review.