Platform docs cleanup #482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
theotherjimmy
commented
Apr 3, 2018
theotherjimmy
commented
- Break platform into 3 major sections
- Introcude relevent concetps in those sections
- Move detailed exampes into Callback docs
- Break platform into 3 major sections - Introcude relevent concetps in those sections - Move detailed exampes into Callback docs
|
@AnotherButler I think I got to all of the cleanup I needed to. |
|
@sg- Could you take a look? |
sg-
reviewed
Apr 4, 2018
| @@ -27,3 +27,156 @@ Here is an example that uses everything discussed in the [introduction to callba | |||
|
|
|||
| - [Platform overview](/docs/development/reference/platform.html). | |||
There was a problem hiding this comment.
This and Intro + related content should now be deleted
There was a problem hiding this comment.
Thanks! I'll do that.
| You can create a Callback directly from a C function or function pointer with the same type: | ||
|
|
||
| ``` c++ | ||
| void dosomething(int) { |
There was a problem hiding this comment.
Great to move the content around but this still violates the no foo/bar rule imo. Make sure to keep another task to make the example useful or tangible
There was a problem hiding this comment.
I think I'd rather just do that now.
|
@sg- Could you take another look? |
Make minor grammar changes.
AnotherButler
approved these changes
Apr 9, 2018
AnotherButler
pushed a commit
that referenced
this pull request
Apr 10, 2018
Make change from #482 to live site.
AnotherButler
pushed a commit
that referenced
this pull request
Apr 10, 2018
Add content from #482 to live site.
AnotherButler
pushed a commit
that referenced
this pull request
Apr 10, 2018
Make changes from #482 to live site.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.