Update Ethernet porting guide. #528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove mention about feature branch, these are now in master. Tell about the README.md in test directory.
| @@ -144,7 +144,7 @@ For general Greentea information, please see the [Greentea](/docs/development/to | |||
|
|
|||
| EMAC tests are in the Mbed OS tree under the `TESTS/network/emac` directory. | |||
|
|
|||
| Greentea socket tests are in the Mbed OS tree under the `TESTS/netsocket` directory. | |||
| Greentea socket tests are in the Mbed OS tree under the `TESTS/network/emac` directory. It contains [README.md](https://github.com/ARMmbed/mbed-os/blob/master/TESTS/network/emac/README.md) to guide setting up the test environment and running test cases. | |||
There was a problem hiding this comment.
We prefer not to link to GitHub. Let's keep this line the way it was.
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| <span class="images"><span>Emac API</span></span> | |||
|
|
|||
| This document describes how to port and test an Ethernet MAC (EMAC) driver to Mbed OS. This code is currently on a feature branch. | |||
| This document describes how to port and test an Ethernet MAC (EMAC) driver to Mbed OS. | |||
Delete sentence as requested in comment for linking best practices.
AnotherButler
approved these changes
May 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove mention about feature branch, these are now in master.
Tell about the README.md in test directory.
@AnotherButler Please review & merge in. We would like to have this before OOB.