Workflow: add details for review #543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jen3andruska can you please help? |
bulislaw
approved these changes
May 30, 2018
| @@ -160,6 +161,8 @@ Each state is time boxed. In most cases, this is sufficient time to move to anot | |||
|
|
|||
| All pull requests must be reviewed. The Arm Mbed CI bot determines the most suitable person to review the pull request and tags that person accordingly. | |||
|
|
|||
| Github dismissed reviewers status after any change to the pull request commit history (adding new commit, rebase). Simple changes like documentation edits or rebase on top of latest master should only require rereview by maintainers. Their approval is sufficient considering it was already approved by a team assigned as a reviewer. | |||
There was a problem hiding this comment.
Should this be 'dismisses' with an 's'? Confused about the change to past tense here. And then, it either dismisses "a reviewer's status after..." or dismisses "reviewers' statuses after..."
Edit for active voice and precise language.
|
@jen3andruska Thanks for the awesome edits 👍 |
|
@AnotherButler No problem, happy to help 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two main changes:
@ARMmbed/mbed-os-maintainers @bulislaw Please review