-
Notifications
You must be signed in to change notification settings - Fork 178
Introduced docs changes to indicate Python 3 compatability #554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@cmonr thanks for the update on docs. As discussed with @BlackstoneEngineering, it's important that we clarify the backwards compatibility problem, as Python 3 tools won't work with OS < v5.8. |
@MarceloSalazar Did you have something more specific in mind aside from e388e15 ? |
@cmonr the last update is great! - I was reviewing an old version :) What would happen if someone attempts to use Python 3 with a previous Mbed OS? |
@MarceloSalazar mbed-cli would most likely error with something cryptic, similar to what @ashok-rao first got when he tried to test on Windows this week. However, I don't like the idea of introducing something that would do a live version check in mbed-cli, since mbed-cli is often used with detached versions of mbed-os, making version confirmation much more nuanced and time consuming. |
This is a serious UX problem and not acceptable. We can't release something that is known to cause serious python traceback errors for many Mbed users. If we don't have time to fix the tools, then let's delay the update on the docs until it's done, and set expectations accordingly. |
@MarceloSalazar Should be doing a similar check with the pip version compatibility? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I do understand the backward compatibility issue @MarceloSalazar mentioned. But from the docs perspective, this looks good to me.
If we decide to go ahead, I'd like to have a known issue open with the release and start working to deliver a fix in a patch release @adbridge FYI |
A fix for what exactly @MarceloSalazar? |
@theotherjimmy see error and proposed solution in ARMmbed/mbed-cli#686 |
So do we have a code dependency for this document? |
@AnotherButler I think so? I'm not sure what a code dependency implies in Handbook PRs. There are a couple of moving pieces still, but here's the remaining list:
|
Should we wait for any of the mbed-os PRs to merge before merging this doc PR? |
@AnotherButler I think we're fine to move forward with this PR outside of the above requirements. In any case, the above notes are all making quick progress on being resolved. |
Copy edit for minor grammar nits and typos.
No description provided.