Skip to content

Fix EventQueue API tutorial bugs #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 20, 2018
Merged

Conversation

yennster
Copy link
Contributor

@yennster yennster commented Aug 13, 2018

Fixed EventQueue API tutorial bugs

@AnotherButler AnotherButler requested a review from geky August 13, 2018 19:27
@geky
Copy link
Contributor

geky commented Aug 17, 2018

@yennster, it looks like the added printf (in the fall handler) will run in irq context?

@yennster
Copy link
Contributor Author

yennster commented Aug 17, 2018

@geky Yes, that's because this tutorial is weird in that it shows you the incorrect way to use interrupt handlers first, and then explains how you fix it.

If you read through the tutorial from top to bottom you will see why the example needs to be "wrong"

@geky
Copy link
Contributor

geky commented Aug 17, 2018

Hmmm, ok, I think we changed before because ironically it was wrong

Delete slash for proper rendering.
@AnotherButler AnotherButler merged commit d807029 into ARMmbed:development Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants