[5.10 OOB] Cellular porting fixes #712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy edit file for precise language ("since" is for time passing, and "because" is for cause and effect; "each other" is for two, and "one another" is for more).
AnotherButler
approved these changes
Sep 6, 2018
bridadan
commented
Sep 6, 2018
| @@ -71,7 +71,7 @@ You can browse the existing `manufacturer-modules` under `features/cellular/fram | |||
|
|
|||
| ### Adding a new cellular module | |||
|
|
|||
| You can probably reuse an existing adaptation since most cellular modules are very similar to each other. | |||
| You can probably reuse an existing adaptation because most cellular modules are similar to one another. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've done a few grammar fixes to help the document read better (FYI @AnotherButler).
I've also fixed a greentea link since #659 was merged.