Skip to content

Update linker script templates to include stack #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2018

Conversation

c1728p9
Copy link
Contributor

@c1728p9 c1728p9 commented Sep 12, 2018

Update the linker script templates to include the ability to adjust the boot stack stack size.

This depends on the code change here:
ARMmbed/mbed-os#8039

@deepikabhavnani
Copy link

deepikabhavnani commented Sep 14, 2018

@c1728p9 - Is this document for Mbed 2 only?

This query is because in our source code linker files we set MBED_BOOT_STACK_SIZE as default to 0x400 but in document sample it is 0x1000.

I remember we set MBED_BOOT_STACK_SIZE for Mbed 2 in targets.json. Can we add that info and update example if bootstrap.md is for bothe Mbed 2 and Mbed 5.

@c1728p9
Copy link
Contributor Author

c1728p9 commented Sep 14, 2018

Hi @deepikabhavnani, I set the default stack size to 4K to match the value in targets.json. The RTOS mbed_lib.json overrides this to 1K when present.

This linker script template is for both 2 and 5. Are you wanting this to be stated more explicitly? Can you elaborate on what you would like updated in bootstrap.md?

@AnotherButler
Copy link
Contributor

@deepikabhavnani Is this code OK to merge, or does @c1728p9 need to make further changes?

@deepikabhavnani
Copy link

Needs changes

Update the linker script templates to include the ability to adjust
the boot stack stack size.
@c1728p9 c1728p9 force-pushed the linker_script_update branch from 0d83f21 to f17f052 Compare October 24, 2018 21:49
@c1728p9
Copy link
Contributor Author

c1728p9 commented Oct 24, 2018

Made changes and rebased to latest.

@AnotherButler AnotherButler merged commit 8175451 into ARMmbed:development Oct 25, 2018
AnotherButler pushed a commit that referenced this pull request Oct 25, 2018
Update linker script templates to include stack, as in PR #739
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants