Add "Docs update" to workflow #746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not only new targets, any target update goes to patch release. This reflects the type "target update" instead of only "new target"
0xc0170
force-pushed
the
dev_update_pr_types
branch
from
b55ed63 to
79e56f7
Compare
cmonr
reviewed
Sep 25, 2018
|
|
||
| #### Test update | ||
|
|
||
| Adding a new test unit or test case. |
There was a problem hiding this comment.
What about updating or removing?
There was a problem hiding this comment.
I'll change it to "update"
There was a problem hiding this comment.
Fixed, let me know if its OK
|
|
||
| Adding a new target is a change for a patch release because it updates the targets folder implementation. | ||
| Updating target implementation (adding a new target or updating already supported target) is a change for a patch release. |
There was a problem hiding this comment.
Updating target implementation -> Updating a target implementation
|
@AnotherButler Can you review please? |
Complete sentences for consistency throughout document.
AnotherButler
approved these changes
Oct 5, 2018
AnotherButler
pushed a commit
that referenced
this pull request
Oct 5, 2018
Add content from #746 after reviewing on test site.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs approval from @ARMmbed/mbed-os-maintainers