Skip to content

Extended advertising added to Gap docs #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

paul-szczepanek-arm
Copy link
Member

@paul-szczepanek-arm paul-szczepanek-arm commented Nov 15, 2018

Update the docs to reflect added BT5 functionality (extended and periodic advertising) introduced in:
ARMmbed/mbed-os#8738

@AnotherButler
Copy link
Contributor

@paul-szczepanek-arm Please add a brief description, and link to the code PR upon which this is dependent.

Make minor copy edits.
@AnotherButler AnotherButler requested a review from pan- November 16, 2018 17:50
Copy link
Contributor

@AnotherButler AnotherButler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this 👍

@AnotherButler
Copy link
Contributor

This PR is waiting on engineering review and a code dependency.

Copy link
Contributor

@donatieng donatieng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth adding a warning about advertising extensions support being optional in Bluetooth 5, otherwise LGTM!

@paul-szczepanek-arm
Copy link
Member Author

@donatieng I addressed your comment, please approve

Copy link
Contributor

@donatieng donatieng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarceloSalazar
Copy link
Contributor

Thank you! Looking forward to having this merged to use it during OOB :)

@AnotherButler AnotherButler merged commit 1566b89 into ARMmbed:development Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants