Skip to content

Cellular: update handbook to 5.11 #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 27, 2018

Conversation

jarvte
Copy link
Contributor

@jarvte jarvte commented Nov 20, 2018

Updated cellular parts to match current implementation after refactoring.

@AriParkkila please review.

@jarvte
Copy link
Contributor Author

jarvte commented Nov 20, 2018

@AnotherButler please review

@jarvte
Copy link
Contributor Author

jarvte commented Nov 21, 2018

@ARMmbed/mbed-docs please review as Amanda is out of office.

@iriark01
Copy link
Contributor

This will probably have to wait for Amanda. We have a release and an OOB campaign this week for other products.

@AnotherButler
Copy link
Contributor

Is there a code dependency on this PR?

Copy link
Contributor

@AnotherButler AnotherButler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see query.

@@ -4,13 +4,13 @@

The CellularBase provides a C++ API for connecting to the internet over a Cellular device.

Arm Mbed OS provides a [reference implementation of CellularBase](http://os-doc-builder.test.mbed.com/docs/development/mbed-os-api-doxy/_easy_cellular_connection_8h_source.html), which has more information.
Arm Mbed OS provides a [reference implementation of CellularBase](http://os-doc-builder.test.mbed.com/docs/development/mbed-os-api-doxy/_cellular_context_8h_source.html), which has more information.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Query: Why do we link to the same Doxy page three times on the same page? Could we get rid of two?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, removed two links.

@@ -119,7 +136,7 @@ Consider the following points when selecting PPP or AT mode:

### Optimize for power consumption

The `CellularPower` class has methods to optimize power saving. The `set_powerl_level()` offers flexibility to control the reception and transmission power levels. In addition, 3GPP has specified advanced power optimizations that are useful for celluar IoT devices: Power Save Mode (PSM) and extended Discontinuous Reception (eDRX).
The `CellularPower` class has methods to optimize power saving. The `set_power_level()` offers flexibility to control the reception and transmission power levels. In addition, 3GPP has specified advanced power optimizations that are useful for celluar IoT devices: Power Save Mode (PSM) and extended Discontinuous Reception (eDRX).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

Edit file, mostly for active voice.

Cellular APIs are structured based on main functionalities:

- `CellularNetwork` for cellular network features, such as preferred operator and APN.
- `CellularContext` is the main interface for the application. You can use it to connect to the operator's APN.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Query: What does APN stand for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jarvte
Copy link
Contributor Author

jarvte commented Nov 27, 2018

Is there a code dependency on this PR?
These changes are related to this pr which is merged: ARMmbed/mbed-os#8579

Teppo Järvelin and others added 2 commits November 27, 2018 08:50
@AnotherButler AnotherButler merged commit 042587a into ARMmbed:development Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants