Skip to content

guidelines: add repository #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 29, 2018

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Nov 26, 2018

Each repo should contain license & contributing information

I added it to the guidelines (new section - new repository). This should be valid for any repository we release. 3 files that are important for contribution.

@ARMmbed/mbed-os-maintainers Please review

@0xc0170
Copy link
Contributor Author

0xc0170 commented Nov 26, 2018

Note, Mbed OS repository follows this. Not all examples but at least some new ones do.
This would be really nice to have in the documentation. Any new repository should conform (the old ones will be done via script later, in 5.12 most likely)

@0xc0170 0xc0170 force-pushed the fix_repository_guide branch 2 times, most recently from 0cdd1ed to ba77db5 Compare November 26, 2018 11:03
Copy link
Contributor

@adbridge adbridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Each repo should contain license & contributing information
@0xc0170 0xc0170 force-pushed the fix_repository_guide branch from ba77db5 to 909db13 Compare November 26, 2018 11:04
@0xc0170
Copy link
Contributor Author

0xc0170 commented Nov 26, 2018

I fixed the links

Each repository must contain:

- `CONTRIBUTING.md` file (similar to [Mbed OS contributing](https://github.com/ARMmbed/mbed-os/blob/master/CONTRIBUTING.md)).
- `LICENSE` file - the full license text or overview of every license in the repo with links.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might not be a question for this PR, but do we need to specify which kind of licenses should be used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add a link here to license page ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yes!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* Licenses: Licenses should comply with the [licenses described here](../contributing/license.html). is above in the first section, should be sufficient for this page

@0xc0170
Copy link
Contributor Author

0xc0170 commented Nov 29, 2018

One thing I noticed - our repos ar emissing templates for issues/pull requests. As a guidance, we might want to document these two. See an example here : ARMmbed/mbed-os-example-mbed-crypto#5

I can send separate PR based on this one to extend what repository should follow. These templates should be a must / should contain. So our scripts work (cloning issues), etc

Fix existing typo, and spell out symbol for consistent style.
@AnotherButler AnotherButler merged commit fcaca14 into ARMmbed:development Nov 29, 2018
@0xc0170 0xc0170 deleted the fix_repository_guide branch November 30, 2018 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants