Skip to content

Add config options range limit notes #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 2, 2019
Merged

Add config options range limit notes #852

merged 3 commits into from
Jan 2, 2019

Conversation

kegilbert
Copy link
Contributor

Additionally add small blurb on how not setting the value field/setting it to null affects the parameter (this might've been described somewhere else, let me know if this is already here and we can remove that portion).

@AnotherButler
Copy link
Contributor

ping @theotherjimmy

@AnotherButler
Copy link
Contributor

@kegilbert Any idea why this is failing CI?

@kegilbert
Copy link
Contributor Author

@AnotherButler Looks like build timeout issues, I don't have permissions to kick off a rebuild can you try that?

@AnotherButler
Copy link
Contributor

I don't have permissions, either. @rik ?

@rik
Copy link
Contributor

rik commented Dec 7, 2018

This is not a timeout issue. It is trying to fetch content from os-doc-builder.test.mbed.com which is only reachable inside the ARM network. We've fixed that in the development branch a week ago (by fetching from os.mbed.com) so if you rebase this on the latest development branch, it should build well.

@kegilbert
Copy link
Contributor Author

Right! Alright, thanks will do!

kegilbert and others added 3 commits December 7, 2018 17:26
@kegilbert
Add notes on value def and range limits
947b6e7 
Add new field options for configuring parameter range limits or accepted values. Add note on how to define a parameter without a default value.
@kegilbert
Update parameter name ref
f87d2de
@kegilbert
Fix tense in configuration.md
06abb2e 
Make edits for minor grammar nits.
@kegilbert
Copy link
Contributor Author

Jimmy approved this, anything else we're waiting on?

@AnotherButler
Copy link
Contributor

Should this go live now, or are we waiting on any code releases first?

@kegilbert
Copy link
Contributor Author

This code is currently live, we should be good to go.

Came in with ARMmbed/mbed-os#8673 for the 5.11 release.

@AnotherButler AnotherButler merged commit 28d6393 into development Jan 2, 2019
@AnotherButler AnotherButler deleted the kegilbert-patch-2 branch January 2, 2019 21:40
AnotherButler pushed a commit that referenced this pull request Jan 2, 2019
Update config option range in configuration.md
5634524 
Make changes from #852 to 5.11 branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theotherjimmy theotherjimmy theotherjimmy approved these changes

@AnotherButler AnotherButler AnotherButler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kegilbert @AnotherButler @rik @theotherjimmy