Add test command to BlockDevice.md #853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add command about porting tests.
AnotherButler
requested review from
MarceloSalazar,
dannybenor and
ashok-rao
dannybenor
reviewed
Nov 28, 2018
| ``` | ||
| mbed test -t <toolchain> -m <target> -n mbed-os-features-storage-tests-blockdevice-general_block_device -v | ||
| ``` | ||
|
|
||
| One way to add tests for new block devices is to copy an existing implementation, such as HeapBlockDevice, and change the block device class to your own. You can find tests under the top level `TESTS` folder in the Mbed OS repository. |
There was a problem hiding this comment.
I think a better pointer for the tests will be https://github.com/ARMmbed/mbed-os/tree/master/features/storage/TESTS/blockdevice instead of "find tests under the top level TESTS folder in the Mbed OS repository"
There was a problem hiding this comment.
Maybe this link should be added as well?
https://github.com/ARMmbed/mbed-os/tree/master/features/storage/TESTS/blockdevice/general_block_device
It contains useful information.
dannybenor
approved these changes
Nov 28, 2018
MarceloSalazar
approved these changes
Nov 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add command about porting tests.