workflow: add request to rewrite the history #887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xc0170
force-pushed
the
dev_workflow_rewrite_git_log
branch
from
a91759e to
0cf91ac
Compare
| @@ -64,6 +64,8 @@ Pull requests on GitHub have to meet the following requirements to keep the code | |||
| - Comment in the pull request on every change (rebase or new commits). This helps reviewers to be up to date with changes | |||
| - Pull requests should fix a bug, add a feature or refactor. | |||
|
|
|||
| If commits do not follow above guidelines, you might be requested to rewrite the history (it is often adding more details to address _what_ and _why_ vs _how_). | |||
There was a problem hiding this comment.
suggestion: requested to rewrite the history -> requested to modify the commit history
0xc0170
force-pushed
the
dev_workflow_rewrite_git_log
branch
from
0cf91ac to
184613d
Compare
|
@cmonr This shoud address you question about when we request changes to the commit history |
0xc0170
force-pushed
the
dev_workflow_rewrite_git_log
branch
from
184613d to
01b9e7a
Compare
When commit history does not provide sufficient details for a reader, we might request updating the commit history. This often happens for new functionality or changing the current one without explaining why are we changing it or how to use a new one. Good example that would lead to change request in the PR is "Initial version for new feature" one-liner in the commit history.
0xc0170
force-pushed
the
dev_workflow_rewrite_git_log
branch
from
01b9e7a to
ea13dae
Compare
|
I added some details to the commit msg |
cmonr
approved these changes
Jan 3, 2019
Make minor edits for precise language.
AnotherButler
approved these changes
Jan 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review: @ARMmbed/mbed-os-maintainers