-
Notifications
You must be signed in to change notification settings - Fork 178
Update example paragraph #907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update example paragraph #907
Conversation
@melwee01 please review |
13e34ae
to
750159a
Compare
|
||
The ESP8266Interface uses AT commands over serial interface to connect to an external Wi-Fi device. The OdinWiFiInterface provides an Ethernet-like driver to the Mbed OS network stack. The network stack uses the driver to connect to Wi-Fi: | ||
|
||
[](https://github.com/ARMmbed/mbed-os-example-wifi/blob/mbed-os-5.10.0/main.cpp) | ||
[](https://github.com/ARMmbed/mbed-os-example-wifi/blob/master/main.cpp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a 5.11 branch or tag for this example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it need to be specifically to 5.11? Master should always point to the latest tag, Seppo says.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we have versioned code, we must have versioned docs (and therefore, versioned examples). Our development branch can point to master, but our live sites should point to versioned examples. If someone's using Mbed OS 5.8, and we include an example from Mbed OS 5.11, which uses features not in 5.8, it'll be confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are 4 different tags for 5.11 for this example, 1 for each RC, but not for the release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have some automation for updating the tags and links when mbed-os release is done, or is this all manual work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's all manual work for now, but we've asked the teams revising the examples process to change that.
Apply example changes from #907 to 5.11.
HTTP part was removed from the example, update also the link to example to point to master.