Skip to content

Fix BlockDevice example #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2019

Conversation

theamirocohen
Copy link
Contributor

The example have been shorten and improved, we now receive the default block device according to the device target configuration.

The example have been shorten and improved, we now receive the default block device according to the device target configuration.
@theamirocohen
Copy link
Contributor Author

@AnotherButler @GuyWi

@AnotherButler AnotherButler requested a review from offirko January 10, 2019 09:24
@AnotherButler
Copy link
Contributor

Thanks for the PR 👍 After these changes merge, please add the example to the docs_only repo.

Copy link
Contributor

@offirko offirko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AnotherButler pushed a commit that referenced this pull request Jan 10, 2019
Change hard-coded example to importable example, as in PR #909
@AnotherButler AnotherButler merged commit 5cf3e7c into ARMmbed:development Jan 10, 2019
AnotherButler pushed a commit that referenced this pull request Jan 10, 2019
Update example, as in PR #909
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants