-
Notifications
You must be signed in to change notification settings - Fork 178
Cellular docs updated #914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bit too much passive voice for my taste, but I don't know that we can afford to be that picky.
ea2cbdf
to
5d364c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I left some comments asking about links I can't get to work. I think maybe that's on the Doxygen/code end?
@AriParkkila Thanks for clarifying. Because this depends on code that hasn't merged yet, I'm going to add a code dependency label. Could you please link to the relevant mbed-os PR? |
@AriParkkila or @mirelachirica Could one of you please let me know which code PR (if there is one) this is waiting for? Also, could you please resolve the merge conflicts? |
@AnotherButler PR has not been made yet. This time we documented it before anything was implemented, so I guess we are learning :) I will rebase and update this when PR is ready. |
@AnotherButler PR for the CellularInterface class ARMmbed/mbed-os#9746 Rebased and ready for merge. |
5d364c1
to
40ac63e
Compare
Cellular docs updated for Mbed OS 5.12.
Porting guide need to be finished later.