Skip to content

Removed PR template from docs #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2019

Conversation

cmonr
Copy link
Contributor

@cmonr cmonr commented Feb 28, 2019

We have this: https://github.com/ARMmbed/mbed-os/blob/master/.github/pull_request_template.md

Do we a duplicate in the docs that then also needs to be maintained?

(For reference, this was brought up by @mrcoulter45 when creating ARMmbed/mbed-os#9895 (comment))

@adbridge
Copy link
Contributor

adbridge commented Mar 1, 2019

IF this repo wants to use any of our scripts properly then it will need to keep the template....

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 1, 2019

The intention was to show an example of good pull request . However it's hard to keep up to date if we improve (=change) things. We have this covered in how to create PR, should be sufficient.

Fine to be removed.

@AnotherButler
Copy link
Contributor

I like not duplicating content that could get out of sync, but not being able to use scripts sounds concerning.

@AnotherButler
Copy link
Contributor

@0xc0170 @adbridge Could y'all please confirm whether this will affect scripts?

@adbridge
Copy link
Contributor

adbridge commented Mar 5, 2019

IF this repo wants to use any of our scripts properly then it will need to keep the template....

The key is this, you don't have to have the template as long as people raise the PRs using the format that is in the template. That format is essential for the scripts. So it is up to you whether you lead people by giving the template automatically, or continually check that people have raised their PRs using the right format. Personally I still think your template is the best option, people rarely read guidelines properly....

@AnotherButler AnotherButler merged commit 4ec7b5c into ARMmbed:development Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants