Use the driver version of private key generation #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrzejKurek
force-pushed
the
private_key_generation
branch
from
d099394 to
8061ace
Compare
gilles-peskine-arm
previously approved these changes
Jun 5, 2019
Patater
previously approved these changes
Jun 11, 2019
AndrzejKurek
dismissed stale reviews from Patater and gilles-peskine-arm
via
74caee6
|
Added a test to make sure that the public key format received when generating a private key is compliant with PSA. |
Patater
reviewed
Jun 11, 2019
main.c
Outdated
| key_type, alg, PSA_KEY_USAGE_VERIFY, pubkey, | ||
| pubkey_len)); | ||
|
|
||
| /* Test that a public key that is exported from a private key - can be |
There was a problem hiding this comment.
I'd suggest to remove the -.
gilles-peskine-arm
previously approved these changes
Jun 17, 2019
Patater
suggested changes
Jun 17, 2019
AndrzejKurek
force-pushed
the
private_key_generation
branch
from
f32beb7 to
020807d
Compare
|
I've rebased the branch to resolve conflicts. |
gilles-peskine-arm
approved these changes
Jun 18, 2019
Patater
approved these changes
Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a prerequisite of ARMmbed/mbed-os-atecc608a#5.