-
Notifications
You must be signed in to change notification settings - Fork 116
Fix deprecated Gap type usages #289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @ARMmbed/mbed-os-pan, @evedon, this PR makes sure examples continue to work after ARMmbed/mbed-os#12730 is merged. The example updates are trivial and there's no dependency on the mbed-os PR though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good but could you add more details in the PR description on the migration actions?
Thanks for the review, I've updated the description. |
@jamesbeyond It looks like the CI result is not reported back to GitHub? Thanks |
@LDong-Arm |
902e703
to
38d1c7e
Compare
now CI works 😉 |
@jamesbeyond Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is now causing PRs failing (master Mbed OS)
|
The mbed-os master branch has long had a typo |
This PR replaces usages of deprecated types in
Gap::
that are not warned by the compiler but will not be available anymore once ARMmbed/mbed-os#12730 is merged. (Note: This does not depend on that PR.)Types replaced:
Gap::Phy_t
->ble::phy_t
Gap::Handle_t
->ble::connection_handle_t
GapAdvertisingData::LE_GENERAL_DISCOVERABLE
->ble::adv_data_flags_t(value).getGeneralDiscoverable()
Gap::CentralPrivacyConfiguration_t
->ble::central_privacy_configuration_t
The legacy types exist in the legacy Gap class only which will be removed from mbed-os. The current Gap APIs only use the new types.