Skip to content

Add CMakelists #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 9, 2020
Merged

Add CMakelists #321

merged 8 commits into from
Nov 9, 2020

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Sep 8, 2020

The CMake support is still in development. For more information, see mbed-os/cmake/README.md

Following ARMmbed/mbed-os#13566

@pan- pan- changed the base branch from master to development September 8, 2020 12:30
@pan-
Copy link
Member

pan- commented Sep 8, 2020

Thanks @0xc0170 I changed the base branch to development. I suppose we have to wait for ARMmbed/mbed-os#13566 to be merged ?

@0xc0170
Copy link
Contributor Author

0xc0170 commented Sep 8, 2020 •
edited
Loading

I need to fix all other example PRs (all targeted master, my bad). I'll get back to this, to provide step by step how to integrate.
My initial proposal was to get first the examples in and test them via Mbed OS PR 13566 (unblocking it).

hugueskamba and others added 7 commits November 9, 2020 10:07
@hugueskamba @0xc0170
Add CMakelists
12a9e1d 
The CMake support is still in development. For more information, see mbed-os/cmake/README.md
@hugueskamba @0xc0170
CMake: Add required Mbed OS component
0bf7c97 
Mbed OS has multiple targets that can be linked to as required.
@hugueskamba @0xc0170
CMake: Add support for BLE_LED and sync with master
23ef402 
This commit syncs the feature-cmake branch with master and adds CMake
support for the BLE_LED example project as the BLE_Button example
project is being removed.
@hugueskamba @0xc0170
CMake: Use renamed Mbed CMake targets component
649432e 
They are now prefixed with "mbed-" instead of "mbed-os-"
@hugueskamba @0xc0170
CMake: Perform toolchain and language setup
838ce33
@0xc0170
CMake: BLE button removal
ae9bcdf
@rajkan01 @0xc0170
CMake: Call mbed_set_post_build API for setting post build operations
cc4d184 
- Update CMake minimum version required from 3.18.2 to 3.19.0
- Replace mbed-os source path MBED_ROOT with MBED_PATH in CMakeLists.txt
@0xc0170
Copy link
Contributor Author

0xc0170 commented Nov 9, 2020

Thanks @0xc0170 I changed the base branch to development. I suppose we have to wait for ARMmbed/mbed-os#13566 to be merged ?

It was merged. I rebased feature-cmake with development, it should be up to date.

This is ready for integration (please squash merge, 1 commit for this simple change).

@paul-szczepanek-arm
Copy link
Member

BLE_LED does not exist anymore, if you just rename BLE_LED to BLE_Advertising it should be fine.

@paul-szczepanek-arm
Copy link
Member

Actually, let me do that.

@0xc0170
Copy link
Contributor Author

0xc0170 commented Nov 9, 2020

Thanks ! I've just noticed the comment :) lets wait for green light

@paul-szczepanek-arm paul-szczepanek-arm merged commit 129c2ca into development Nov 9, 2020
@0xc0170 0xc0170 deleted the feature-cmake branch November 9, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@0xc0170 @pan- @paul-szczepanek-arm @hugueskamba @rajkan01