Add basic stats reporting to blinky. #144
Conversation
cmonr
requested review from
MarceloSalazar,
AnotherButler,
janjongboom,
SenRamakri and
bulislaw
|
|
||
| * [Mbed OS Stats API](https://os.mbed.com/docs/latest/apis/mbed-statistics.html) | ||
| * [Mbed OS Configuration](https://os.mbed.com/docs/latest/reference/configuration.html) | ||
| * [Mbed OS Serial Communication](https://os.mbed.com/docs/latest/tutorials/serial-communication.html) |
There was a problem hiding this comment.
@kegilbert - Maybe we can point to other stats examples as well - https://github.com/ARMmbed/mbed-os-example-cpu-stats
There was a problem hiding this comment.
The stats API link has examples on that page inline that are pulled from the teams repo which is copied from the github repo (quite the path...). I can add the github links as well if we'd like a direct link to the Github hosted examples (the docs site does lose the README info).
There was a problem hiding this comment.
If the stats API link has the links already we ca skip adding them here.
kegilbert
force-pushed
the
quick-start-blinky
branch
from
5cbe320 to
18e9fe0
Compare
|
@janjongboom Does that look a bit nicer? |
|
@kegilbert Ack, I think stdint is not required if we include mbed.h, but OK. Isn't |
| { | ||
| "target_overrides": { | ||
| "*": { | ||
| "platform.stdio-baud-rate": 115200, |
There was a problem hiding this comment.
We should check with docs team if changing this will require docs change too, as we now need to specify the baud rate in any place where we mention serial.
There was a problem hiding this comment.
Quick start makes mention of it, but pinging @AnotherButler to double check.
|
@0xc0170 Ran through astyle and added headers and some rudimentary comments. I initially had everything in just a header file due to its size but can break it out to a proper file format as the additional comments are making it a bit larger. @SenRamakri Added the ROM/RAM reporting stats as well. Along with that and the refactoring may want to double check it. @janjongboom |
cmonr
dismissed
0xc0170’s stale review
Styling and license changes addressed.
kegilbert
force-pushed
the
quick-start-blinky
branch
from
5179cf9 to
1cd815e
Compare
|
@0xc0170 Updated, thanks for the catch! |
Acts as an update to the quick start experience Update license notes
kegilbert
force-pushed
the
quick-start-blinky
branch
from
1cd815e to
5e06f70
Compare
Acts as an update to the quick start experience. Moving from:
https://github.com/armmbed/mbed-os-quick-start-blinky to this repo to avoid having old versions floating around.
@janjongboom @bulislaw @SenRamakri