Skip to content

Set the baudrate to default and reduce prints in blinky #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 8, 2019
Merged

Set the baudrate to default and reduce prints in blinky #155

merged 2 commits into from
Jan 8, 2019

Conversation

deepikabhavnani
Copy link

Issue: #153

@deepikabhavnani deepikabhavnani mentioned this pull request Jan 4, 2019
Closed
kegilbert
kegilbert reviewed Jan 5, 2019
View reviewed changes
@kegilbert
Copy link
Contributor

LGTM besides a minor style nit. This will cause a minor blip in the blinking rate every 10 seconds which shouldn't be a problem (I haven't run the new changes yet, not sure on how noticeable it will be).

Before this is merged we need a PR up to update the documentation as well.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 7, 2019

Before this is merged we need a PR up to update the documentation as well.

in the docs or here in readme?

0xc0170
0xc0170 reviewed Jan 7, 2019
View reviewed changes
mbed_app.json
@@ -1,7 +1,6 @@
{
"target_overrides": {
"*": {
"platform.stdio-baud-rate": 115200,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@deepikabhavnani
Copy link
Author

Before this is merged we need a PR up to update the documentation as well.
in the docs or here in readme?

Updated the Readme. @kegilbert - Let me know if anything else should be updated

@kegilbert kegilbert mentioned this pull request Jan 7, 2019
Merged
@kegilbert
Copy link
Contributor

kegilbert commented Jan 7, 2019 •
edited
Loading

ARMmbed/mbed-os-5-docs#891 Put up, this PR is good to go on my end.

@deepikabhavnani
Copy link
Author

deepikabhavnani commented Jan 7, 2019 •
edited
Loading

ARMmbed/mbed-os-5-docs#891 Put up, this PR is good to go on my end.

Thanks

@0xc0170 0xc0170 merged commit 5f56aa0 into ARMmbed:master Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kegilbert kegilbert kegilbert approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deepikabhavnani @kegilbert @0xc0170