-
Notifications
You must be signed in to change notification settings - Fork 157
add log compare test for blinky example #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tests/README.md
Outdated
``` | ||
|
||
|
||
More details about `htrun` are [here](https://github.com/ARMmbed/htrun#testing-mbed-os-examples). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link is not working anymore (htrun moved)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link is fixed.
Question: how do I maintain this log (generate a new one, just need to edit it as I understand right) - any change to example needs log update. |
the detailed instruction is in that fixed link, the log will like to be manually maintained, they just standard RegEx. if any one change the example the log will need to be updated. |
I am thinking that this does not test at all that the blinking happens. What you think about adding "led on" and "led off" prints to the file and check that at least couple of those are there? Then we know at least that board is not in stuck. For sure we don't know if led is on really but at least logic works. |
@jamesbeyond please review, and send separate PR |
I think that wouldn't be necessary. printing |
Add a log compare test for this example for enable example CI testing