Skip to content

add log compare test for blinky example #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2019
Merged

Conversation

jamesbeyond
Copy link
Contributor

Add a log compare test for this example for enable example CI testing

tests/README.md Outdated
```


More details about `htrun` are [here](https://github.com/ARMmbed/htrun#testing-mbed-os-examples).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link is not working anymore (htrun moved)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link is fixed.

@0xc0170
Copy link
Contributor

0xc0170 commented May 14, 2019

Question: how do I maintain this log (generate a new one, just need to edit it as I understand right) - any change to example needs log update.

@jamesbeyond
Copy link
Contributor Author

Question: how do I maintain this log (generate a new one, just need to edit it as I understand right) - any change to example needs log update.

the detailed instruction is in that fixed link, the log will like to be manually maintained, they just standard RegEx. if any one change the example the log will need to be updated.

@OPpuolitaival
Copy link

I am thinking that this does not test at all that the blinking happens. What you think about adding "led on" and "led off" prints to the file and check that at least couple of those are there? Then we know at least that board is not in stuck. For sure we don't know if led is on really but at least logic works.

@0xc0170 0xc0170 merged commit 0b8957a into ARMmbed:master May 15, 2019
@0xc0170
Copy link
Contributor

0xc0170 commented May 15, 2019

I am thinking that this does not test at all that the blinking happens. What you think about adding "led on" and "led off" prints to the file and check that at least couple of those are there? Then we know at least that board is not in stuck. For sure we don't know if led is on really but at least logic works.

@jamesbeyond please review, and send separate PR

@jamesbeyond
Copy link
Contributor Author

I am thinking that this does not test at all that the blinking happens. What you think about adding "led on" and "led off" prints to the file and check that at least couple of those are there? Then we know at least that board is not in stuck. For sure we don't know if led is on really but at least logic works.

I think that wouldn't be necessary. printing led on/led off are not equivalent to the LED is physically on or off. that will require manual checks. also the on and off logic is fairly simple. in this test we just want to make sure the example wasn't crash/broken badly from beginning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants