This repository was archived by the owner on Apr 24, 2019. It is now read-only.
Using thread signals instead of restarting a thread #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this still valid? |
|
Yes, just tried with the latest master and the POST doesn't work the second time. After applying this fix the POST works as expected. Looks like the history has gotten a bit goofed up with this branch though, I will close this PR and reopen from my fork. |
|
Well actually after going through the history of this PR it looks like your CI doesn't handle forks? In that case I'm just force pushing to this branch again. |
bridadan
force-pushed
the
fix_blinky_thread
branch
from
5d813b7 to
2cc89ae
Compare
|
rebuild |
teetak01
approved these changes
Nov 24, 2017
The blinky thread was being restarted everytime a POST was received. This wasn't working correctly for multiple POST requests, it would only work for the first POST request. This is also a very heavyweight action. This uses thread signals instead and keeps the blink thread alive for the whole application
bridadan
force-pushed
the
fix_blinky_thread
branch
from
2cc89ae to
2c8ff1b
Compare
|
Rebased! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Migrations
NO
Description
The blinky thread was being restarted everytime a POST was received.
This wasn't working correctly for multiple POST requests, it would only
work for the first POST request. This is also a very heavyweight action.
This uses thread signals instead and keeps the blink thread alive for
the whole application
Todos
Deploy Notes
Notes regarding deployment the contained body of work.
Steps to Test or Reproduce
Clone master and try POSTing twice. I have reproduced the failure on the NUCLEO_F429ZI in the online compiler.
Impacted Areas in Application