This repository was archived by the owner on Apr 24, 2019. It is now read-only.
Added a boolean to disable blinky ticker when a blink pattern is posted #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mikaleppanen Is there an issue for the CI of this repo? |
|
rebuild |
|
@yogpan01, I've just reviewed the build failure. I cannot get this to compile with IAR on master, either. Can you? |
|
rebuild |
1 similar comment
|
rebuild |
|
ok fixed now, there was a minor Linux != Windows script incompatibility issue... |
|
@sarahmarshy can you please rebase your PR ? The IAR CI build job is now fixed. |
|
These changes are covered in #79, hence closing this one |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The blink pattern was not being updated properly with Post requests because of the status ticker. I have added a boolean to disable the ticker from updating the LED when a blink pattern is executing.