Skip to content

adding two example config files for: #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ATM-HSW
Copy link

@ATM-HSW ATM-HSW commented May 29, 2020

Both example configs are tested together with NUCLEO_L073RZ, which is part of the P-NUCLEO-LRWAN1 package, Mbed OS 5.14.2 and uVision 5.28.
P-NUCLEO-LRWAN2 was used as a gateway to TTN.

Copy link
Contributor

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: since ARMmbed/mbed-os#12741, Semtech Lora radio drivers are now mbed-os component

Comment on lines +9 to +11
"lora-spi-mosi": { "value": "NC" },
"lora-spi-miso": { "value": "NC" },
"lora-spi-sclk": { "value": "NC" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't you set default values to D11.D12.D13 ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't you set default values to D11.D12.D13 ?

I used the same config structure as already used by the other two examples. An advantage of this is, that it is clear which board should work.
Of course every pin config could be done in the default section. When you thing that this is the better solution I'll move it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no preference, just question :-)

@ATM-HSW
Copy link
Author

ATM-HSW commented Jun 1, 2020

FYI: since ARMmbed/mbed-os#12741, Semtech Lora radio drivers are now mbed-os component

Maybe somebody responsible for the repository can add the necessary changes. Up to now I don't use Mbed OS 6. And the above pull request is part of the new version.

@paul-szczepanek-arm
Copy link
Member

This is now redundant, yes? @jeromecoutant

@paul-szczepanek-arm paul-szczepanek-arm changed the base branch from master to development January 14, 2021 17:51
@jeromecoutant
Copy link
Contributor

This is now redundant, yes? @jeromecoutant

For me, default pins should not be defined as an "example" in this appli.
So I think this PR is not relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants