Ensure Nanostack is initialised before using it #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nanostack initialisation will occur after the first call to: Nanostack::get_instance Set file system root path after Nanostack initialisation.
|
@kjbracey-arm , @SeppoTakalo |
SeppoTakalo
approved these changes
Jun 8, 2018
SeppoTakalo
reviewed
Jun 8, 2018
| ns_file_system_set_root_path("/fs/"); | ||
| // Should be like: Nanostack::get_instance().file_system_set_root_path("/fs/"); |
There was a problem hiding this comment.
I don't understand what you are trying to say with this comment?
Proposal for a new API?
There was a problem hiding this comment.
You got it right, that kind of API should be added later on.
SeppoTakalo
pushed a commit
that referenced
this pull request
Jun 18, 2018
* origin/mbed-os-5.9.0-oob: Update SD Card usage instructions to README (#194) Updating mbed-os to mbed-os-5.9.0-rc3 Ensure Nanostack is initialised before using it (#192) Added known issue re: NVM. Added links to issues in known issues list Fixed broken links and added known issue for Mbed OS 5.9 Updating mbed-os to mbed-os-5.9.0-rc2 Updating mbed-os to mbed-os-5.9.0-rc1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nanostack initialisation will occur after the first call to:
Nanostack::get_instance
Set file system root path after Nanostack initialisation.