Add and fix size restrictions to targets #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your changes. |
|
run-ci |
teetak01
approved these changes
Mar 20, 2020
There was a problem hiding this comment.
Look good.
@MarceloSalazar could you get some more reviewers for this?
esajaa
force-pushed
the
restrict_app_sizes
branch
from
877804e to
823bcc6
Compare
|
Thanks - looks good |
|
yes, this is purely compile-time check to verify that the application does not overflow to bank2. |
MarceloSalazar
approved these changes
Mar 20, 2020
toyowata
reviewed
Mar 20, 2020
toyowata
reviewed
Mar 20, 2020
toyowata
approved these changes
Mar 24, 2020
|
@esajaa rebase & merge. |
Used following target.restrict_size calculation method: For 1MB bank: Hex 0x100000 (=Dec 1024 * Dec 1024) - target.app_offset = target.restrict_size For 512KB bank: Hex 0x080000 (=Dec 512 * Dec 1024) - target.app_offset = target.restrict_size
esajaa
force-pushed
the
restrict_app_sizes
branch
from
4675b26 to
2311744
Compare
|
build-only |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Added size restrictions to several boards, and also fixed some previous ones that were too large or too small.
Used target.restrict_size calculation method:
For 1MB bank: Hex 0x100000 (=Dec 1024 * Dec 1024) - target.app_offset = target.restrict_size
For 512KB bank: Hex 0x080000 (=Dec 512 * Dec 1024) - target.app_offset = target.restrict_size
[x] I confirm this contribution is my own and I agree to license it with Apache 2.0.
[x] I confirm the moderators may change the PR before merging it in.
For new board enablements only:
[] I confirm the board is Mbed Enabled and passes the Mbed Enabled test set.
[] I confirm the contribution has been tested properly and the tests results for TESTS are attached.
[] I confirm
mbed-os.libandmbed-cloud-client.libhashes or the content in foldersmbed-osandmbed-cloud-clientwere not modified in order to pass the tests.