-
Notifications
You must be signed in to change notification settings - Fork 34
Add ESP32 Wi-Fi driver for Renesas GR-LYCHEE #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide new E2E test-results using the WIFI_ESP32. To me it seems that the target is not using this driver (considering that it compiles even without the driver).
Should the esp32.provide-default be set to true for this target to enable the driver?
Yes it should. GR_LYCHEE does not seem to have Ethernet at all, it only has ESP32. |
@teetak01 @JanneKiiskila E2E test-results (same as here)
|
I really do not like that practice. ISM43362 is also silently enabling it for some boards. It would be better that application would always have to enable the driver if it actually wants to use it. Well, this is one reason we use the COMPONENT formalism as these would cause suprise-issues if some board is used with different network-stack than some driver is expecting. |
build-only |
[x] I confirm this contribution is my own and I agree to license it with Apache 2.0.
[x] I confirm the moderators may change the PR before merging it in.
Summary of changes
I added the ESP32 Wi-Fi driver which accidentally missed in the PR #96