Skip to content

Add ESP32 Wi-Fi driver for Renesas GR-LYCHEE #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 28, 2020

Conversation

toyowata
Copy link
Contributor

[x] I confirm this contribution is my own and I agree to license it with Apache 2.0.
[x] I confirm the moderators may change the PR before merging it in.

Summary of changes

I added the ESP32 Wi-Fi driver which accidentally missed in the PR #96

@iot-pdmc
Copy link
Collaborator

Thanks for your changes.
@ARMmbed/pdmc-integrators please review.

Copy link
Contributor

@teetak01 teetak01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide new E2E test-results using the WIFI_ESP32. To me it seems that the target is not using this driver (considering that it compiles even without the driver).

Should the esp32.provide-default be set to true for this target to enable the driver?

@JanneKiiskila
Copy link

Should the esp32.provide-default be set to true for this target to enable the driver?

Yes it should. GR_LYCHEE does not seem to have Ethernet at all, it only has ESP32.

@toyowata
Copy link
Contributor Author

@teetak01 @JanneKiiskila
The GR-LYCHEE board has on-board ESP32 module and the esp32.provide-default is defined here: https://github.com/ARMmbed/esp32-driver/blob/d6bd83f8710b4c475b3cce101d8b2c77e17feaf6/mbed_lib.json#L49

E2E test-results (same as here)

============================== 4 passed in 39.15s ==============================
2020-01-15 10:58:02,240:tests.conftest:MainThread:INFO: -----  TEST RESULTS SUMMARY  -----
2020-01-15 10:58:02,240:tests.conftest:MainThread:INFO: [ check the complete fail reasons and code locations from this log or html report ]
2020-01-15 10:58:02,241:tests.conftest:MainThread:INFO: [passed] - dev-client-tests.py::test_01_get_device_id - (0.772s)
2020-01-15 10:58:02,241:tests.conftest:MainThread:INFO: [passed] - dev-client-tests.py::test_02_put_resource - (4.831s)
2020-01-15 10:58:02,242:tests.conftest:MainThread:INFO: [passed] - dev-client-tests.py::test_03_get_resource - (1.839s)
2020-01-15 10:58:02,242:tests.conftest:MainThread:INFO: [passed] - dev-client-tests.py::test_04_subscribe_resource - (3.470s)

@teetak01
Copy link
Contributor

I really do not like that practice. ISM43362 is also silently enabling it for some boards. It would be better that application would always have to enable the driver if it actually wants to use it.

Well, this is one reason we use the COMPONENT formalism as these would cause suprise-issues if some board is used with different network-stack than some driver is expecting.

@teetak01
Copy link
Contributor

build-only

@iot-pdmc
Copy link
Collaborator

@teetak01 teetak01 merged commit 80263c8 into ARMmbed:master Jan 28, 2020
@toyowata toyowata deleted the dev_esp32 branch January 29, 2020 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants