This repository was archived by the owner on Jun 8, 2021. It is now read-only.
Rearrange tls-related function calls and add explicit set_hostname() #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #40, the example started failing on connection. It turns out that:
set_ca_cert()
must go beforeopen()
set_hostname()
is required for this connection to work (our Greentea tests work fine without it).The second point must be considered separately, as the
TLSSocket::connect
was removed with the recent changes in string-based APIs, but it seems it might have to stay to call theset_hostname
...