Skip to content

Authcrypt - stop using \r\n and use just \n #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

JanneKiiskila
Copy link
Contributor

There is a fix via small mbed_app.json trick to get the proper C-style
linechanges working.

@JanneKiiskila
Copy link
Contributor Author

@andresag01 @k-stachowiak

There is a fix via small `mbed_app.json` trick to get the proper C-style
linechanges working.
@JanneKiiskila
Copy link
Contributor Author

CI issues?

[build-authcrypt-K64F-ARM] c:\jsbld\ws\mbed-os\e_g_pr_tls@4>rmdir /S /Q . 
[build-authcrypt-K64F-ARM] .\TLS-CL~2\DURABL~1\jenkins-log.txt - The process cannot access the file because it is being used by another process.
[build-authcrypt-K64F-ARM] The process cannot access the file because it is being used by another process.
[Pipeline] [build-authcrypt-K64F-ARM] checkout
[build-authcrypt-K64F-ARM] Cloning the remote Git repository
[build-authcrypt-K64F-ARM] Cloning repository [email protected]:ARMmbed/mbed-os-example-tls.git
[build-authcrypt-K64F-ARM] ERROR: Failed to clean the workspace
[build-authcrypt-K64F-ARM] java.nio.file.FileSystemException: c:\jsbld\ws\mbed-os\e_g_pr_tls@4\tls-client@tmp\durable-19ffe8a3\jenkins-log.txt: The process cannot access the file because it is being used by another process.
[build-authcrypt-K64F-ARM] 

@andresag01
Copy link

@JanneKiiskila: Thanks for the PR. I was unaware of that particular mbed OS configuration option and always relied on configuring the serial terminal. I think the PR is looking good (I have not fully reviewed it though). My only concern is that merging this as is also means that now the printing is not consistent throughout all the example apps.

@andresag01
Copy link

andresag01 commented Oct 17, 2017

@JanneKiiskila: Indeed, there were some CI issues in the previous build that were not related to the change. I have triggered another build, but I do not think there will be any issues.

@k-stachowiak

@JanneKiiskila
Copy link
Contributor Author

I can do the rest of the apps under mbed-os-example-tls as well, it's trivial.

@JanneKiiskila
Copy link
Contributor Author

Anyway, the printouts are consistent from end user point of view.

@AndrzejKurek
Copy link
Contributor

The changes look ok, but having the problems with our CI - I'd like to rerun the testing.

@andresag01
Copy link

@JanneKiiskila: Thank you for your contribution! I wanted to make sure all the sample applications are consistent. Therefore, I created the PR #126 which is a superset of these changes. Therefore, I am closing this. I hope you do not mind...

@andresag01 andresag01 closed this Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants