-
Notifications
You must be signed in to change notification settings - Fork 51
Authcrypt - stop using \r\n and use just \n #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There is a fix via small `mbed_app.json` trick to get the proper C-style linechanges working.
6f00c18
to
05773a7
Compare
CI issues?
|
@JanneKiiskila: Thanks for the PR. I was unaware of that particular mbed OS configuration option and always relied on configuring the serial terminal. I think the PR is looking good (I have not fully reviewed it though). My only concern is that merging this as is also means that now the printing is not consistent throughout all the example apps. |
@JanneKiiskila: Indeed, there were some CI issues in the previous build that were not related to the change. I have triggered another build, but I do not think there will be any issues. |
I can do the rest of the apps under mbed-os-example-tls as well, it's trivial. |
Anyway, the printouts are consistent from end user point of view. |
The changes look ok, but having the problems with our CI - I'd like to rerun the testing. |
@JanneKiiskila: Thank you for your contribution! I wanted to make sure all the sample applications are consistent. Therefore, I created the PR #126 which is a superset of these changes. Therefore, I am closing this. I hope you do not mind... |
There is a fix via small
mbed_app.json
trick to get the proper C-stylelinechanges working.