Separate server name #174
Separate server name #174
Conversation
Seperate the server_name into the `server_addr` which is the address to connect, and to `server_name` which is the server host_name. Sometimes these are not the same
There was a problem hiding this comment.
@RonEld: I think I am happy with the changes, but before approving: what use case do you have in mind for this case? I can see this could be very useful when using the SNI extension, but I dont think thats the case here. Please remember that this is supposed to be a simple example of a tls client and adding more features generally tends to make it harder to follow...
tls-client/HelloHttpsClient.cpp
Outdated
| server_port(in_server_port), | ||
| /* The platform context is passed just in case any crypto calls need it. | ||
| * Please refer to https://github.com/ARMmbed/mbedtls/issues/1200 for more | ||
| * information. */ | ||
| platform_ctx(in_platform_ctx) | ||
|
|
There was a problem hiding this comment.
Could you please remove this whitespace?
|
@andresag01 I agree that the examples should be simple, |
|
@RonEld: Thanks for answering my question. I will approve the PR after the whitespace is removed. |
Remove an additional extra line added by a merge conflict.
|
@andresag01 I removed the extra whitespace which was accidentally introduced in a merge conflict resolution |
|
All the relevant tests in the CI pass. |
Seperate the server_name into the
server_addrwhich is the address to connect,
and to
server_namewhich is the server host_name.Sometimes these are not the same, and it helps separating them for connecting to other servers