Minor improvements to the app #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest uvisor |
1 similar comment
|
retest uvisor |
AlessandroA
force-pushed
the
minor_fixes
branch
from
2cadb78 to
96812b6
Compare
|
Created issue #17 to fix this. |
This helps keeping track of who is doing what.
The memcmp check was only checking the first byte of the namespace.
Although this is not ideal from a security perspective, for this example we want to share the Serial object to make sure that the app log does not get messed up by multiple threads trying to write to the serial port. For this purpose, we explicitly instantiated a `shared_pc` Serial object, instead of silently using `printf` as-is.
AlessandroA
force-pushed
the
minor_fixes
branch
from
96812b6 to
85d3c8b
Compare
|
retest uvisor |
|
LGTM. Merge when CI passes. |
|
retest uvisor |
1 similar comment
|
retest uvisor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These improvements get us much closer to the addition of new targets to this app.