led3: thread type fix #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not use internal rtx type. This will be removed from our includes soon.
|
The cleanup happens ARMmbed/mbed-os#7364. This fix however do not require it, as the mbed thread storage type is already in the codebase just not used here |
|
/morph uvisor-test |
orenc17
previously approved these changes
Jul 4, 2018
|
All green , should be good to go |
alzix
previously approved these changes
Jul 4, 2018
0xc0170
commented
Jul 4, 2018
source/led3.cpp
Outdated
| @@ -62,7 +62,7 @@ static void led3_main(const void *) | |||
| SecureAllocator alloc = secure_allocator_create_with_pages(4 * kB, 1 * kB); | |||
| /* Prepare the thread definition structure. */ | |||
| osThreadAttr_t thread_attr = {0}; | |||
| mbed_rtos_storage_thread_t thread_def = {0}; | |||
There was a problem hiding this comment.
I think we should use this mbed storage instead, so no RTX types
There was a problem hiding this comment.
Oren. I was about to send same comment. But Martin was faster.
This is mbed-os-example-* mbed-os types are most appropriate here.
alzix
approved these changes
Jul 4, 2018
|
/morph uvisor-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not use internal rtx type. This will be removed from our includes soon.