Removed hooks from main file #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
meriac
commented
Sep 19, 2016
meriac
commented
- Requires uVisor: Debug Box & ENET DMA-support for default box mbed-os#2733 to work
- Requires ARMmbed/mbed-os#2733 to work
|
mbed OS CI is broken with this being merged... http://10.118.12.43:8081/job/mbed-os-examples-build/61/toolchain=GCC_ARM/console Should this type of change be aligned with a patch level release? |
|
@sg- I talked it through with @mazimkhan and breaking our uVisor example first to allow verification of the more general #2733 to mbed-os made more sense to us. By applying the above mentioned patch mbed-os we should get this example working again. What is your advice? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.