Add Alarm example to docs #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kegilbert
force-pushed
the
add-alarm-example
branch
from
a8d6e24 to
005a3ad
Compare
cmonr
approved these changes
Nov 29, 2018
added 2 commits
November 29, 2018 11:37
Edit file, mostly for branding and formatting.
Edit comments for active voice and phrasing
AnotherButler
approved these changes
Nov 29, 2018
|
What's the preference on merging examples in this repo? Is this something maintainers want to lead, or shall we merge it? |
|
@AnotherButler I think merging responsability can be shared? We do code checks. y'all do the docs checks. As long as a PR has an ok from each side, I think either team can merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving examples here as our per our group discussion @cmonr @AnotherButler
mbed-os.lib is currently pointing to master.