-
Notifications
You must be signed in to change notification settings - Fork 26
Add USBCDC_ECM example #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -0,0 +1,11 @@ | |||
## USBCDC_ECM example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One the API documentation merges, I'll update this README to point to it in a new PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR 👍 This looks great.
ping @0xc0170 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although this is docs, it's providing code without license information? This might not block this PR but rather create separate issue and fix to address this.
@AnotherButler Please review
@@ -0,0 +1,27 @@ | |||
#include "mbed.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we dont include license headers to the code files? Like this one, we have this documented in our license guide. If anyone copies this, should also copy the copyright + license. PLease add
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've checked some files, some have some don't . All should so please add it here and should be LGTM
Added the Licence text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@0xc0170 Can you please merge this? It's telling me I can't. |
You should be able to, if not, please email us (maintainers) , will review |
Thank you 👍 If it doesn't let me again, I'll let you know. |
No description provided.