Skip to content

Add USBCDC_ECM example #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2019
Merged

Add USBCDC_ECM example #50

merged 2 commits into from
May 29, 2019

Conversation

juhaylinen
Copy link
Contributor

No description provided.

@@ -0,0 +1,11 @@
## USBCDC_ECM example
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One the API documentation merges, I'll update this README to point to it in a new PR.

Copy link
Contributor

@AnotherButler AnotherButler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 👍 This looks great.

@AnotherButler AnotherButler requested a review from 0xc0170 April 18, 2019 16:39
@AnotherButler
Copy link
Contributor

ping @0xc0170

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this is docs, it's providing code without license information? This might not block this PR but rather create separate issue and fix to address this.

@AnotherButler Please review

@@ -0,0 +1,27 @@
#include "mbed.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we dont include license headers to the code files? Like this one, we have this documented in our license guide. If anyone copies this, should also copy the copyright + license. PLease add

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked some files, some have some don't . All should so please add it here and should be LGTM

@mikter mikter requested a review from 0xc0170 May 22, 2019 08:44
Added the Licence text
Copy link

@artokin artokin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AnotherButler
Copy link
Contributor

@0xc0170 Can you please merge this? It's telling me I can't.

@0xc0170 0xc0170 merged commit ae89bd7 into master May 29, 2019
@0xc0170
Copy link
Contributor

0xc0170 commented May 29, 2019

@0xc0170 Can you please merge this? It's telling me I can't.

You should be able to, if not, please email us (maintainers) , will review

@AnotherButler
Copy link
Contributor

Thank you 👍 If it doesn't let me again, I'll let you know.

@AnotherButler AnotherButler deleted the usb branch May 29, 2019 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants