Merge pull request #108 from bridadan/correct_return_codes

Only return positive return codes

Author: theotherjimmy

packages/mbed-greentea/mbed_greentea/mbed_greentea_cli.py

@@ -78,8 +78,6 @@
     run_test_thread,
 )
 
-RET_NO_DEVICES = 1001
-RET_YOTTA_BUILD_FAIL = -1
 LOCAL_HOST_TESTS_DIR = './test/host_tests'  # Used by mbedhtrun -e <dir>
 
 
@@ -339,7 +337,7 @@ def main():
             except KeyboardInterrupt:
                 greentea_clean_kettle(gt_instance_uuid)
                 gt_logger.gt_log_err("ctrl+c keyboard interrupt!")
-                return(-2)    # Keyboard interrupt
+                return 1    # Keyboard interrupt
             except:
                 greentea_clean_kettle(gt_instance_uuid)
                 gt_logger.gt_log_err("unexpected error:")
@@ -353,7 +351,7 @@ def main():
             cli_ret = main_cli(opts, args)
         except KeyboardInterrupt:
             gt_logger.gt_log_err("ctrl+c keyboard interrupt!")
-            return(-2)    # Keyboard interrupt
+            return 1    # Keyboard interrupt
         except Exception as e:
             gt_logger.gt_log_err("unexpected error:")
             gt_logger.gt_log_tab(str(e))
@@ -364,6 +362,8 @@ def main():
         gt_logger.gt_log("completed in %.2f sec"% delta)
 
     if cli_ret:
+        if cli_ret < 0 or cli_ret > 255:
+            cli_ret = 1
         gt_logger.gt_log_err("exited with code %d"% cli_ret)
 
     return(cli_ret)

packages/mbed-host-tests/mbed_host_tests/mbedhtrun.py

@@ -28,15 +28,18 @@ def main():
              2. Call default test execution function run() to start test instrumentation
     """
     freeze_support()
-    result = -2
+    result = 1
     test_selector = DefaultTestSelector(init_host_test_cli_params())
     try:
         result = test_selector.execute()
     except (KeyboardInterrupt, SystemExit):
         test_selector.finish()
-        result = -3
         raise
     else:
         test_selector.finish()
 
+    # Ensure we don't return a negative value
+    if result < 0 or result > 255:
+        result = 1
+
     return result

packages/mbed-ls/mbed_lstools/main.py

@@ -189,7 +189,7 @@ def mbedls_main():
 
     if mbeds is None:
         logger.critical('This platform is not supported! Pull requests welcome at github.com/ARMmbed/mbed-ls')
-        sys.exit(-1)
+        sys.exit(1)
 
     ret_code = args.command(mbeds, args)
     if not ret_code: