Skip to content

Only return positive return codes #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 22, 2019
Merged

Only return positive return codes #108

merged 3 commits into from
Jan 22, 2019

Conversation

bridadan
Copy link
Contributor

Description

Should fix #76. All CLI packages should now only return positive return codes. Its a bit hard to know for sure since there are quite a bit of returns/exits scattered throughout the code base, hopefully that can be cleaned up in the future.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

theotherjimmy
theotherjimmy approved these changes Jan 22, 2019
View reviewed changes
Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious as to why this is a problem.

@theotherjimmy
Copy link
Contributor

Doubling down on those merge master into commits.

@theotherjimmy theotherjimmy merged commit 72a9beb into ARMmbed:master Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theotherjimmy theotherjimmy theotherjimmy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[test] Greentea's negative return codes misinterpreted on some platforms
2 participants
@bridadan @theotherjimmy