Skip to content

Add and updated cypress kits in the platform database #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 14, 2019

Conversation

miteshdedhia7
Copy link
Contributor

@miteshdedhia7 miteshdedhia7 commented Jul 19, 2019

Description

Add Cypress PSoC6 kits to the platform database. The Board IDs are as assigned by @maclobdell
Added and updated the following kits,
CYW9P62S1_43012EVB_01: 1903 (Updated)
CY8CKIT_062S2_4343W: 1905 (Updated)
CY8CPROTO_064_SB: 1907 (Added)
CYW9P62S1_43438EVB_01: 1908 (Added)
CY8CKIT_062S2_43012: 190B (Added)
CY8CPROTO-062S3-4343W: 190E (Added)

The corresponding change to mbed-os targets is ongoing.

Pull request type

[ ] Fix
[ ] Refactor
[x ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@maclobdell @vmedcy

@maclobdell
Copy link
Contributor

@cy-midd - Can you please confirm the correct value for the board with ID '190E'

I received notification from Vita that, "CY8CPROTO-062S2-4343W should be renamed to CY8CPROTO-062S3-43012." Please confirm if that is still correct. You may need to update your PR.

@ARMmbed/mbed-os-tools - Please review and approve once the above entry is confirmed.

@miteshdedhia7
Copy link
Contributor Author

@maclobdell I double checked the kits and I can confirm the for 190E the kit is CY8CPROTO-062S3-4343W. The current data in the pull request is correct. Apologies for the confusion, I believe the internal ARM database also have to be updated since the initial value that was submitted was CY8CPROTO-062S3-43012 which was incorrect.

@maclobdell
Copy link
Contributor

@ARMmbed/mbed-os-tools - this should be ready to go. Please review.

@maclobdell
Copy link
Contributor

@madchutney - are you planning to merge this request and do a release?

@madchutney
Copy link
Contributor

@maclobdell This should go out with the next OS patch release.

@maclobdell
Copy link
Contributor

@madchutney - thanks a lot. Just to clarify, you plan to merge this PR, then make a release, which will be added to the requirements.txt in mbed-os for release 5.13.3? this will be ready in time for code freeze this week, right?

@madchutney
Copy link
Contributor

@maclobdell I've run into a problem, the online database doesn't match the values being submitted here. Can you update the database please?

@maclobdell
Copy link
Contributor

@madchutney - sorry about that, I normally do not bother updating the database to add the target names for pre-released boards. I have done that now.

However, I just discovered two problems. @cy-midd - Can you help resolve these issues?

First - this value in this PR is using dashes (-) instead of underscores. We recommend underscores (_).

'190E': u'CY8CPROTO-062S3-4343W',

Second - several target names are 21 characters long. However, our system will only accept target names of 20 character or less.

Can you reduce the number of characters by 1 or more?

u'1903': u'CYW9P62S1_43012EVB_01',
u'1908': u'CYW9P62S1_43438EVB_01',
u'1909': u'CY8CPROTO_062S2_43012',
u'190E': u'CY8CPROTO-062S3-4343W',

Keep in mind that these values will need to match the target name in mbed-os/targets/targets.json when a pull request is made to add these targets to Mbed OS.

@mark-edgeworth
Copy link
Contributor

Unable to pass the last couple of tests because of issues with posting to Coveralls. I'll keep trying, but this is out of our control at the moment.

@miteshdedhia7
Copy link
Contributor Author

@maclobdell I updated the "-" to "_" that was an error. As for the target name length, we are trying to get feedback internally from our marketing team to find the best way to resolve this issue.

@mark-edgeworth mark-edgeworth merged commit aef119e into ARMmbed:master Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants