Skip to content

Added support for EP_AGORA #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 20, 2019
Merged

Added support for EP_AGORA #189

merged 4 commits into from
Aug 20, 2019

Conversation

millerc-ep
Copy link
Contributor

@millerc-ep millerc-ep commented Aug 19, 2019 •
edited
Loading

Description

Added support for EP_AGORA

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@maclobdell @trowbridgec @loverdeg-ep

@0Grit
Copy link

0Grit commented Aug 19, 2019

@trowbridgec

0Grit
0Grit suggested changes Aug 19, 2019
View reviewed changes
Copy link

@0Grit 0Grit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to "AGORA-DEV"

@millerc-ep millerc-ep changed the title Added support for EPM2M-AG-CELL Added support for AGORA-DEV Aug 19, 2019
mark-edgeworth
mark-edgeworth reviewed Aug 20, 2019
View reviewed changes
Copy link
Contributor

@mark-edgeworth mark-edgeworth left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears as EP_AGORA in the platforms database 'board-type' entry, and 'AGORA_DEV' as the slug.

mark-edgeworth
mark-edgeworth suggested changes Aug 20, 2019
View reviewed changes
Copy link
Contributor

@mark-edgeworth mark-edgeworth left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be EP_AGORA to match the board type entry in the os.mbed.com platform database. If you can make this change I can approve and get this into the next tools release (probably today).

@millerc-ep millerc-ep changed the title Added support for AGORA-DEV Added support for EP_AGORA Aug 20, 2019
mark-edgeworth
mark-edgeworth approved these changes Aug 20, 2019
View reviewed changes
Copy link
Contributor

@mark-edgeworth mark-edgeworth left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Provided this passes the checks then I can bring it in today thanks.

@mark-edgeworth mark-edgeworth merged commit 82979a3 into ARMmbed:master Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-edgeworth mark-edgeworth mark-edgeworth approved these changes

@0Grit 0Grit 0Grit approved these changes

@trowbridgec trowbridgec trowbridgec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@millerc-ep @0Grit @mark-edgeworth @trowbridgec