Skip to content

Use return code 0 when all tests are skipped #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2019
Merged

Use return code 0 when all tests are skipped #200

merged 1 commit into from
Oct 10, 2019

Conversation

OPpuolitaival
Copy link
Contributor

Description

In Mbed OS pull request checks we use --skip-test to skip tests which did pass already. In case of all tests are skipped greentea returns 1. This PR change to return zero when all tests are skipped. This makes Greentea to behave more similar way that another test frameworks.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

mark-edgeworth
mark-edgeworth approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@mark-edgeworth mark-edgeworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable that if nothing is tested then nothing has failed...

@mark-edgeworth
Copy link
Contributor

Incidentally we (build tools) are not responsible for the greentea stuff (and testing code in general). @jamesbeyond is the owner for this code, so he might want to comment....

jamesbeyond
jamesbeyond approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@jamesbeyond jamesbeyond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This make sense, we should not throw error when no match test found, Warning in log should be good enough

@OPpuolitaival
Copy link
Contributor Author

Rebased. Ready for merge from my point of view

@OPpuolitaival OPpuolitaival merged commit e1a3eea into ARMmbed:master Oct 10, 2019
@OPpuolitaival OPpuolitaival deleted the greentea branch October 10, 2019 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-edgeworth mark-edgeworth mark-edgeworth approved these changes

@jamesbeyond jamesbeyond jamesbeyond approved these changes

@madchutney madchutney Awaiting requested review from madchutney

@JuhPuur JuhPuur Awaiting requested review from JuhPuur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OPpuolitaival @mark-edgeworth @jamesbeyond