Skip to content

Remove decode call from report content write #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2019
Merged

Remove decode call from report content write #202

merged 1 commit into from
Oct 18, 2019

Conversation

JuhPuur
Copy link
Contributor

@JuhPuur JuhPuur commented Oct 15, 2019

Description

This one decode call breaks reporting for python3.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@JuhPuur
Copy link
Contributor Author

JuhPuur commented Oct 15, 2019

CI appears to fail on pip install error.

@JuhPuur
Copy link
Contributor Author

JuhPuur commented Oct 15, 2019

Tested to work with python 2.7. Looks like CI machine is missing a tool.

@madchutney madchutney requested review from jamesbeyond and removed request for mark-edgeworth October 16, 2019 09:00
jamesbeyond
jamesbeyond approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@jamesbeyond jamesbeyond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OPpuolitaival OPpuolitaival merged commit 1bbbe70 into ARMmbed:master Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OPpuolitaival OPpuolitaival OPpuolitaival approved these changes

@jamesbeyond jamesbeyond jamesbeyond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JuhPuur @OPpuolitaival @jamesbeyond