Skip to content

Commit acdd7dd

Browse files
authored
Merge pull request #4837 from theotherjimmy/fix-export-builds
Correct supported check in exporter tests
2 parents 2305a8c + 8b31078 commit acdd7dd

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

tools/test/examples/examples_lib.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ def target_cross_ide(allowed_targets, allowed_ides, features=[], toolchains=[]):
115115
"""
116116
for target in allowed_targets:
117117
for ide in allowed_ides:
118-
if (target in EXPORTERS[ide].TARGETS and
118+
if (EXPORTERS[ide].is_target_supported(target) and
119119
(not toolchains or EXPORTERS[ide].TOOLCHAIN in toolchains) and
120120
all(feature in TARGET_MAP[target].features
121121
for feature in features)):

tools/toolchains/__init__.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -692,7 +692,8 @@ def _add_dir(self, path, resources, base_path, exclude_paths=None):
692692
# Recursively scan features but ignore them in the current scan.
693693
# These are dynamically added by the config system if the conditions are matched
694694
def closure (dir_path=dir_path, base_path=base_path):
695-
return self.scan_resources(dir_path, base_path=base_path)
695+
return self.scan_resources(dir_path, base_path=base_path,
696+
collect_ignores=resources.collect_ignores)
696697
resources.features.add_lazy(d[8:], closure)
697698
resources.ignore_dir(dir_path)
698699
dirs.remove(d)

0 commit comments

Comments
 (0)