Skip to content

Correct supported check in exporter tests #4837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2017

Conversation

theotherjimmy
Copy link
Contributor

Is blocking the release. Whoops

@theotherjimmy
Copy link
Contributor Author

/morph export-build

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 102

Exporter Build failed!

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 1, 2017

Is blocking the release. Whoops

I would rather want to know why is this fix needed (root cause of this bug). At the moment, this still fails, and we need to investigate this regression. When checking for changes in tools/test/examples/examples_lib.py, I dont suspect this file is to blame, but somewhere else in the recent days.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 1, 2017

Found it, this is related to the changeset introduced #4725. However, between that one and this one something broke gccarmeclipse.

If I export locally, I get different error for K64F (tried 2 different machines), linker error that an object file was not found (compilation is fine, compare to the result that comes from CI here).

@theotherjimmy
Copy link
Contributor Author

/morph export-build

1 similar comment
@theotherjimmy
Copy link
Contributor Author

/morph export-build

@mbed-bot
Copy link

mbed-bot commented Aug 1, 2017

Result: ABORTED

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 104

Example Prep failed!

@theotherjimmy
Copy link
Contributor Author

/morph export-build

@mbed-bot
Copy link

mbed-bot commented Aug 1, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 103

Exporter Build failed!

@theotherjimmy
Copy link
Contributor Author

build 103 is old. 105 incoming.

@mbed-bot
Copy link

mbed-bot commented Aug 1, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 105

All exports and builds passed!

@0xc0170 0xc0170 removed the needs: CI label Aug 2, 2017
@0xc0170 0xc0170 merged commit acdd7dd into ARMmbed:master Aug 2, 2017
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 2, 2017

Note: this is dependent on #4783, that I cherry picked to resolve another error in the release candidate caused by this, and not have seen here on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants