-
Notifications
You must be signed in to change notification settings - Fork 3k
Correct supported check in exporter tests #4837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b8b7fab
to
4510563
Compare
/morph export-build |
Result: FAILUREYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 102 Exporter Build failed! |
I would rather want to know why is this fix needed (root cause of this bug). At the moment, this still fails, and we need to investigate this regression. When checking for changes in tools/test/examples/examples_lib.py, I dont suspect this file is to blame, but somewhere else in the recent days. |
Found it, this is related to the changeset introduced #4725. However, between that one and this one something broke gccarmeclipse. If I export locally, I get different error for K64F (tried 2 different machines), linker error that an object file was not found (compilation is fine, compare to the result that comes from CI here). |
4510563
to
ca0c2a8
Compare
/morph export-build |
1 similar comment
/morph export-build |
0acc762
to
8b31078
Compare
Result: ABORTEDYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 104 Example Prep failed! |
/morph export-build |
Result: FAILUREYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 103 Exporter Build failed! |
build 103 is old. 105 incoming. |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 105 All exports and builds passed! |
Note: this is dependent on #4783, that I cherry picked to resolve another error in the release candidate caused by this, and not have seen here on master |
Is blocking the release. Whoops