Skip to content

cellular: remove last CELLULAR_DEVICE references #10005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from Mar 20, 2019
Merged

cellular: remove last CELLULAR_DEVICE references #10005

merged 1 commit into from Mar 20, 2019

Conversation

ghost
Copy link

@ghost ghost commented Mar 8, 2019

Description

CellularTargets.h removed to get rid of last CELLULAR_DEVICE references. Tested with the cellular example

Pull request type

[ X ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@AriParkkila

@ciarmcom ciarmcom requested review from AriParkkila and a team March 8, 2019 10:00
@ciarmcom
Copy link
Member

ciarmcom commented Mar 8, 2019

@TeemuKultala, thank you for your changes.
@AriParkkila @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

AriParkkila
AriParkkila suggested changes Mar 11, 2019
View reviewed changes
Copy link

@AriParkkila AriParkkila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove CellularTargets.h also from features/cellular/TESTS.

Change doxygen of CellularDevice.h to something like "Returns singleton instance of CellularDevice if Mbed target board has a supported onboard modem or provide-default is defined for a cellular driver in JSON configuration files, otherwise returns NULL. See NetworkInterface::get_default_instance for details."

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 11, 2019

@AriParkkila Please rereview

@TeemuKultala When push an update, please leave a comment what has changed (helps reviewers to get back to you with additional questions or approval)

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 14, 2019

I've just noticed, this needs rebase now

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 16, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 16, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@cmonr
Copy link
Contributor

cmonr commented Mar 17, 2019

Hmm, there was a slghtly older cellular PR that just came in that's caused this PR to need a rebase.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 18, 2019

CI restarted

@TeemuKultala When rebased , please let us know via comment

@mbed-ci
Copy link

mbed-ci commented Mar 18, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit c6d3d83 into ARMmbed:master Mar 20, 2019
@ghost ghost deleted the cellular_remove_device branch May 13, 2019 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release-version: 5.12.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ciarmcom @0xc0170 @mbed-ci @cmonr @AnttiKauppila @AriParkkila